Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer discovery type in config to object #878

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Jan 29, 2021

Making PeerDiscovery options to Object by now. Otherwise, ts projects will fail to build as they will need to add discovery modules configuration. This should only be done when we type the modules

Closes #876

@vasco-santos vasco-santos force-pushed the fix/make-peer-discovery-type-to-any branch from 49834bf to 3436ba3 Compare January 29, 2021 13:11
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a tactical fix, pending a proper one

@vasco-santos vasco-santos changed the title fix: peer discovery type in config to any fix: peer discovery type in config to object Jan 29, 2021
@vasco-santos vasco-santos merged commit 3e7594f into master Jan 29, 2021
@vasco-santos vasco-santos deleted the fix/make-peer-discovery-type-to-any branch January 29, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants