fix: the API of es6-promisify is not the same as promisify-es6 #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced by #896 `promisify-es6` was swapped for `es6-promisify` but the APIs of the two modules are no the same so the NAT hole punching code broke. Also changes port numbers to 0 in the tests as other processes can be listening on those ports which causes spurious test failures.
|
The UDP ports are opened by the I've added a test that would have caught the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #896
promisify-es6was swapped fores6-promisifybut the APIs of the two modules are no the same so the NAT hole punching code broke and stopped libp2p nodes UDP ports open which prevented processes from exiting.Also changes port numbers to 0 in the tests as other processes can be listening on those ports which causes spurious test failures.