This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
feat: support PeerInfo.create(IdJSON, cb) as well #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
victorb
reviewed
Dec 14, 2017
|
|
||
| Creates a new PeerInfo instance from an existing PeerID. | ||
| Creates a new PeerInfo instance from an existing PeerId. |
There was a problem hiding this comment.
Correction: Creates a new PeerInfo instance from an existing PeerId or creates a new PeerId for you.
There was a problem hiding this comment.
new PeerId doesn't do that. Users have always to resort to PeerInfo.create because creating a PeerId requires async calls (WebCrypto)
victorb
reviewed
Dec 14, 2017
| @@ -5,28 +5,29 @@ const chai = require('chai') | |||
| const dirtyChai = require('dirty-chai') | |||
| chai.use(dirtyChai) | |||
| const expect = chai.expect | |||
| const PeerId = require('peer-id') | |||
| const Id = require('peer-id') | |||
There was a problem hiding this comment.
Why the renames from PeerId -> Id and PeerInfo -> Info? Previous names were more clearer (without context)
There was a problem hiding this comment.
I noticed there were multiple errors where PeerInfo.create({bits: 512}) appeared, which is a typo since only PeerId supports that option. My diagnostic is that it was hard to differentiate the two words.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.