Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Ping protocol #22

Closed
Nashatyrev opened this issue Jul 11, 2019 · 3 comments
Closed

Implement Ping protocol #22

Nashatyrev opened this issue Jul 11, 2019 · 3 comments
Assignees
@Nashatyrev
Labels
good first issue Good for newcomers

Comments

@Nashatyrev
Copy link
Collaborator

https://docs.rs/libp2p-ping/0.10.0/libp2p_ping/
depends on #16
@Nashatyrev Nashatyrev added the good first issue Good for newcomers label Jul 11, 2019
@snazha-blkio snazha-blkio self-assigned this Jul 18, 2019
@snazha-blkio
Copy link
Contributor

Implemented but on-hold until I can verify the stream impl is correct?

@Nashatyrev Nashatyrev mentioned this issue Aug 31, 2019
Merged
@jezhiggins
Copy link
Contributor

The ping protocol interoperates with go libp2p without issue, both as sender and receiver. As far as I can tell it also interops with Rust libp2p (the Rust library is harder/less obvious than go). I think it's fine and we can close this issue.

@Nashatyrev
Copy link
Collaborator Author

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nashatyrev Nashatyrev

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jezhiggins @Nashatyrev @snazha-blkio