Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about moving wasm-timer into the rust-libp2p/misc ? #2653

Closed
koushiro opened this issue May 17, 2022 · 5 comments
Closed

How about moving wasm-timer into the rust-libp2p/misc ? #2653

koushiro opened this issue May 17, 2022 · 5 comments

Comments

@koushiro
Copy link
Contributor

How about moving wasm-timer into the rust-libp2p/misc dir, like #2641 did.

/cc @mxinden @tomaka

@koushiro
Copy link
Contributor Author

Maybe quicksink also needs to be moved to the misc dir?

@mxinden
Copy link
Member

mxinden commented May 18, 2022

How about moving wasm-timer into the rust-libp2p/misc dir

I would much rather like to see it replaced with a timing library that is still actively maintained. See #2497 (comment). Contributions would be very much appreciated.

Maybe quicksink also needs to be moved to the misc dir?

Any particular reason for that?


In general, while I am a big fan of mono-repos, I would like to:

  • Keep things useful (and used) outside of libp2p outside the monorepo.
  • Ideally reduce the maintenance work on the rust-libp2p maintainers rather than increasing it.

@koushiro
Copy link
Contributor Author

koushiro commented May 18, 2022

Maybe quicksink also needs to be moved to the misc dir?

Any particular reason for that?

quicksink is used for libp2p-websocket, but this repo has been archived by paritytech.

I'm not sure if there is an alternative of this library.

@mxinden
Copy link
Member

mxinden commented May 22, 2022

Instead of moving another generic library into the rust-libp2p monorepo, I think we can replace the use of quicksink in libp2p-websocket instead. Not a strong opinion, though would prefer not increasing the maintenance work on us long term.

@thomaseizinger
Copy link
Contributor

I'll close this as not planned. wasm-timer is unmaintained and we are moving away from it in #3973 at least for gossipsub.

@thomaseizinger thomaseizinger closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants