-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/lib: Add libp2p-tls to development_transport #3060
Comments
Those functions are problematic IMO, at least how they are currently used (inside tests and examples), see #3056. I also think the naming is off. "development" to me suggests that this is something I use during testing but not in production. It also doesn't fit in well with the executor-specific features that we are currently implementing. I can see a "recommended" stack being useful but then it should be rename and I don't think we should use the recommended stack in tests and examples. Tests should use a transport as simple as possible (probably memory + plaintext). For the larger examples, using that recommended transport works because we are already in the libp2p crate. For all other transports, we would introduce a circular dependency again. We can either move those examples or inline it there. In general, I'd prefer if we make composing upgrades simpler and less verbose so the value of these convenience functions is basically 0 and we don't lose anything from deleting them. |
Tests will eventually use #2888. For the examples, we could move away from regular cargo examples and instead introduce an |
Cross-referencing an idea here: #3635 (comment) |
Closing this in favor of #3657. |
Once
libp2p-tls
is no longer analpha
(which it is today, see below) I suggest we add it to ourdevelopment_transport
convenience method.Thoughts?
rust-libp2p/transports/tls/Cargo.toml
Lines 1 to 6 in 4d1b165
rust-libp2p/src/lib.rs
Line 182 in 4d1b165
The text was updated successfully, but these errors were encountered: