Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interop: stop testing webtransport with sec and mux #218

Closed
mxinden opened this issue Jul 3, 2023 · 0 comments · Fixed by #219
Closed

interop: stop testing webtransport with sec and mux #218

mxinden opened this issue Jul 3, 2023 · 0 comments · Fixed by #219

Comments

@mxinden
Copy link
Member

mxinden commented Jul 3, 2023

Based on the logs we seem to be testing the WebTransport Transport across the security and multiplexer dimension:

Running test spec: go-v0.24 x go-v0.28 (webtransport, tls, yamux)
Finished: go-v0.24 x go-v0.24 (wss, noise, mplex) { handshakePlusOneRTTMillis: 11.253, pingRTTMilllis: 1.863 }
Running test spec: go-v0.24 x go-v0.28 (webtransport, noise, yamux)
Finished: go-v0.24 x go-v0.28 (webtransport, tls, yamux) { handshakePlusOneRTTMillis: 103.277, pingRTTMilllis: 2.847 }

https://github.com/libp2p/test-plans/actions/runs/5441933224/jobs/9896488441?pr=217

Given that WebTransport Transport leverages QUIC, there is no additional security and multiplexer upgrade required. Something is off here.

Am I missing something @MarcoPolo?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(interop): use standaloneTransports as string instead of param libp2p/test-plans
1 participant
@mxinden