Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

Any interest in allow rack.processes metric submission to be disabled? #74

Open
samandmoore opened this issue May 12, 2017 · 1 comment

Comments

@samandmoore
Copy link
Contributor

Hi,

I'm curious if you'd be willing to accept a PR to disable the rack.processes metric.

I use this gem through the awesome librato-rails gem, and i disable all of the fancy suites that come with the librato-rails gem. I was surprised to find that even with those suites disabled, this metric still comes through.

So, would you be interested in some sort of configuration option to disable that metric submission? Specifically, this is the relevant line:

queue.add 'rack.processes' => { value: 1, tags: tags }

Thanks. I appreciate the library and your time!

@chancefeick
Copy link
Contributor

Hi @samandmoore

Thanks for the issue. It seems reasonable to allow rack.processes to be configurable as well.

I would recommend making the metric part of the existing rack metric suite: https://github.com/librato/librato-rack#metric-suites

At a quick glance, you should be able to handle it like this:

if suite_enabled?(:rack)
  queue.add 'rack.processes' => { value: 1, tags: tags }
end

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants