Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-scroll to current chapter #4566

Closed
3 tasks done
NeeRaj-2401 opened this issue Aug 21, 2023 · 6 comments · Fixed by #5933
Closed
3 tasks done

Auto-scroll to current chapter #4566

NeeRaj-2401 opened this issue Aug 21, 2023 · 6 comments · Fixed by #5933
Labels
enhancement New feature or request help wanted Looking for help priority: low

Comments

@NeeRaj-2401
Copy link
Contributor

Steps to reproduce

  1. Open video (with chapters)
  2. Click on chapter name which is in player controls

Expected behavior

should Open chapters bottom sheet with scrolled and highlighted to clicked chapter name,
and
if the chapter sheet is already open then scroll and highlight to chapter name which is clicked.

Actual behavior

everytime we click on chapter name inside the player controls, a new instance of chapters bottom sheet gets created.

LibreTube version

latest debug after #4563

Android version

12

Other details

The chapter highlighting part was there in previous chapters ui, hence i mentioned it.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@NeeRaj-2401 NeeRaj-2401 added the bug Something isn't working label Aug 21, 2023
@Bnyro Bnyro added enhancement New feature or request priority: low and removed bug Something isn't working labels Aug 21, 2023
@Bnyro Bnyro changed the title Limit Chapter Bottom Sheet instance Scroll to and highlight current chapter Aug 21, 2023
@NeeRaj-2401
Copy link
Contributor Author

There two more things to address releated to chapter's bottom sheet. Idk i should raise new issue or not hence mentioning here first

  1. Minimising player with chapter's sheet open should actually minimise/close the chapters sheet ( just like comments)
  2. Chapters card's inner layout have some boxy look, the lighter part should be bit rounded

@Bnyro
Copy link
Member

Bnyro commented Aug 25, 2023

That screenshot looks really strange, that's not how it's supposed to look and how it does look on my phone. Weird Android stuff again.

@Bnyro
Copy link
Member

Bnyro commented Aug 25, 2023

should be fixed now :)

@Bnyro Bnyro changed the title Scroll to and highlight current chapter Atuo-scroll to current chapter Aug 25, 2023
@NeeRaj-2401
Copy link
Contributor Author

Yup the chapter card part looks fine now :)
But

  1. clicking on player's chapter name open/close chapter sheet, doesn't auto-scroll to current chapter name

  2. While interacting with player with chapter sheet open, the minimising player behaviour is still not same as it is with comments sheet

@Bnyro
Copy link
Member

Bnyro commented Aug 25, 2023

  1. I've already been looking into that auto-scrolling thing to the current chapter, but there seems to be an Android bug that it just doesn't scroll at all.
  2. Is the intended behavior. Imo, chapters have a different relevance than comments and hence should be dismissed first before minimizing the player.

@Bnyro Bnyro added the help wanted Looking for help label Aug 25, 2023
@NeeRaj-2401
Copy link
Contributor Author

NeeRaj-2401 commented Aug 25, 2023

  1. Aah okay, thanks for letting me know :)

  2. But imo, keeping the same behaviour brings consistency cause personally i got confused for a sec that why player didn't get minimised .
    ( also if user wants to minimise tha chapter sheet , there is already bar for it just below the Player )

@Bnyro Bnyro changed the title Atuo-scroll to current chapter Auto-scroll to current chapter Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Looking for help priority: low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants