Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse YouTube links in search bar #4774

Closed
3 tasks done
hanimebeast opened this issue Sep 14, 2023 · 3 comments · Fixed by #4818
Closed
3 tasks done

Parse YouTube links in search bar #4774

hanimebeast opened this issue Sep 14, 2023 · 3 comments · Fixed by #4818
Labels
enhancement New feature or request

Comments

@hanimebeast
Copy link

Describe your suggested feature

While pasting the youtube link into search bar, the video results rendered. but in case of the provided link with arguements(?foo=bar), args should be automatically split and link should be filter and the resulting result should render because arguement makes the backend error and no result found!

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@hanimebeast hanimebeast added the enhancement New feature or request label Sep 14, 2023
@Bnyro Bnyro changed the title Search Bar Parse YouTube links in search bar Sep 14, 2023
@FineFindus
Copy link
Contributor

This is also how the official YouTube search handles it, adding an unknown parameter to the searched URL, will return no result.
YouTube Seach wuth no result

@vvkdev
Copy link

vvkdev commented Sep 17, 2023

Not all arguments should be splitted, imo. For example, a time argument (&t=) should not. It would be nice if the app open video at that time. I think we need to know exactly which arguments to proceed and which to remove.

@FineFindus
Copy link
Contributor

YouTube parses both feature=shared and t=2 correctly. That's why I said that it only fails for unknown parameters.

YouTube search searching for a link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants