-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] drop cronet #6867
Comments
https://gitlab.com/fdroid/fdroid-suss/-/blob/master/suss/com.google.android.gms.yml It seems to just be the media3 cronet dependency. This is likely because of this: Maybe we can ask them if it's okay to use it without the gms dependency? |
If there's a big issue with the dependency, we could just copy the Java code from the dependency into LibreTube's code (since its apache 2), or maintain a minimal version of the library? Edit: see https://github.com/FireMasterK/LibreTube/tree/media3-cronet |
I don't think that inlining the whole Cronet source code is a good idea and I don't want to maintain a fork of an external library either, so I'll probably remove Cronet with the next release until there's a better solution. |
Describe your suggested feature
F-Droid recently started marking Cronet unfree and thus LibreTube must be dropping that dependency to continue being updated on F-Droid, see #6455.
The whole downloader depends on Cronet, so that'll require a large refactor.
Other details
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: