Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shebang missing in map-poller.php #86

Open
JulianvP opened this issue Sep 26, 2022 · 2 comments
Open

Shebang missing in map-poller.php #86

JulianvP opened this issue Sep 26, 2022 · 2 comments

Comments

@JulianvP
Copy link

For my installation of librenms (which was a pre-build vm-image) the map-poller.php needs the shebang #!/usr/bin/env php in order to be executed correctly by cron.

@cjwbath
Copy link

cjwbath commented Sep 29, 2022

This is the same for my manual install. As an alternative they could adjust the cron entry to add the php executable (which is what I did as a manual workaround). Not sure which is considered better practice.

@appleguy010
Copy link

Can confirm this is an issue.
Documentation here calls for the following cron job
*/5 * * * * librenms /opt/librenms/html/plugins/Weathermap/map-poller.php >> /dev/null 2>&1
This cron job depends on the shebang that should be at the top of map-poller.php, but isn't.
The documentation could be updated with a new cron job with the php command added at the front, but this would not be optimal because someone who simply clones the newest git (like me) would have their current installation break (which it did).

This issue started with this commit in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants