v0.6-dev - binary size increase

[michaelherger]

I see that the binaries for 0.6-dev have increased in size considerably compared to the previous 0.6. A release build on macOS/arm64 would now be up to 7.2MB from 4.3MB. Is this to be expected? Or did I miss something?

[photovoltex]

Could you include your compile command? Or is it without any adjustments?

[michaelherger]

It's admittedly my own fork. I'm currently going through dependencies, to see whether after merging 0.6-dev I'm importing more than I did before. Haven't even pushed it to Github yet... (https://github.com/michaelherger/librespot/tree/spotty-dev)

[photovoltex]

It might be because we include new protobuf definitions for the dealer. Or related to some dependency changes. I'm currently unable to check, but you could try to exclude the dealer commit and check if that makes the difference.

[michaelherger]

FWIW: stripped un-touched dev branch is about 15MB vs. 12MB before dealer. So some growth is there in that work. It's possible that I did exclude some stuff before, which now has been re-introduced by all the refactoring. Thanks a ton for your work anyway!

[photovoltex]

Seems to match up to your reported 3MB size increase. I will take a look into it later.

Wouldn't be surprised if I included too many proto definitions by accident. But I'm kinda surprised that these changes made such a big impact on the size of the binary. Might also just be rust... but will see