Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating url dependency #368

Closed
mainrs opened this issue Sep 9, 2019 · 2 comments · Fixed by #665
Closed

Updating url dependency #368

mainrs opened this issue Sep 9, 2019 · 2 comments · Fixed by #665
Labels
dependencies

Comments

@mainrs
Copy link

mainrs commented Sep 9, 2019

Hey everyone!

Is there a particular reason why you guys stick to the 1.7.x versions of the url crate? I am using librespot in a project where I need to use the new 2.x version as the project uses serde 1.x.

If not, I would gladly create a PR to update the dependencies! :)
@ashthespy
Copy link
Member

No particular reason, I am running 2.x for a while now with no issues (ashthespy@0f959ce)

@sashahilton00
Copy link
Member

Feel free to upgrade to url 2.2 @sirwindfield if you need it, or any other dependencies for that matter.

@Johannesd3 Johannesd3 mentioned this issue Feb 23, 2021
Merged
@Johannesd3 Johannesd3 mentioned this issue Apr 10, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tokio migration librespot-org/librespot
3 participants
@sashahilton00 @mainrs @ashthespy