Playback crashes when switching users

[mikeszila]

I do not use username or password options when starting librespot. I can connect to librespot with multiple different clients as long as they are the same user. If I then try to connect with a client logged in with a different user, librespot crashes. I don't even have to press play for this to happen. Below is the only output when this happens. Previous versions of librespot did not exhibit this behaviour, though I'm not sure when it started.

DEBUG librespot_connect::discovery] Post "/" {}
DEBUG librespot_connect::spirc] drop Spirc[0]
DEBUG librespot_playback::player] Shutting down player thread ...

The only way to connect with a different user us to remove the credentials.json file in the cache folder then restart librespot, but then it's locked into whichever client connects next forever. This makes it difficult for friends and family to make use of librespot.

I'm not sure if this is the same issue or not. Other than the title and basic symptoms it looks different to me. #523 If it matters I use the pipe backend.

[mikeszila]

Is this considered normal behaviour? Is there anything else I could provide to help convey the issue?

[sashahilton00]

Is that built with the latest commit? There were some cache issues that I let slip through in a PR. Doesn't look like the problem that was reported, but deleting credentials.json to resolve suggests it may be related

[sashahilton00]

I wonder if

librespot/connect/src/discovery.rs

Line 81 in f67ceb5

"activeUser": "",

is somewhat responsible, in that if a client tries to connect when a user is active, it might send an action such as logoutUser, which removes the active user before logging the new one in. Having said that though, I believe account switching should just work, it shouldn't be sticking with one account forever so to speak.

We may need to investigate further, will tag with reverse engineering for now.

[roderickvd]

Is this still an issue on vanilla librespot (i.e. not repackaged with ncspot or Spotifyd or the like)? Recently I have tested switching back and forth users and cannot reproduce this.

[roderickvd]

Closing, no further feedback.