Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move get_credentials function to the application #596

Closed
Johannesd3 opened this issue Feb 9, 2021 · 0 comments · Fixed by #665
Closed

Move get_credentials function to the application #596

Johannesd3 opened this issue Feb 9, 2021 · 0 comments · Fixed by #665

Comments

@Johannesd3
Copy link
Contributor

I would like to suggest another breaking change before 0.2: removing fn get_credentials. Why? It does not provide any functionality directly concerning Spotify, but it's rather a very specialized function, written with a concrete application/daemon in mind.

Yes, spotifyd uses this function too, or better: they abuse it. Instead of prompting in the prompt callback they abort the application. Which shows that this function is too specialized for their usecase too.

So I would suggest moving it to the application. It's not hard to implement, so every dependency using this function could implement it's own more spezialized function. Do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant