Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak? #677

Closed
Johannesd3 opened this issue Mar 20, 2021 · 5 comments · Fixed by #665
Closed

Memory Leak? #677

Johannesd3 opened this issue Mar 20, 2021 · 5 comments · Fixed by #665

Comments

@Johannesd3
Copy link
Contributor

When running Librespot (release mode) and skipping through playlists, the used memory increases slowly but steady. It starts with 2-3MB, but after a while I was able to reach 8MB.

It seems to happen in both the dev and the tokio_migration branch.

@kingosticks
Copy link
Contributor

8MB sounds like approx. two 'normal' length tracks worth of compressed audio data. Could this be the track prefetching working correctly?

@Johannesd3
Copy link
Contributor Author

I just stopped at 8MB, probably it's possible to reach more. Every time I skip a track, memory usage grows by something between nothing and 0.5MB.

@kingosticks
Copy link
Contributor

Maybe share your cache settings and which backend also.

@Johannesd3
Copy link
Contributor Author

Johannesd3 commented Mar 20, 2021

I'm using rodio-backend under Windows, no cache enabled.

I tried different configurations out, and it's possible (but I'm not really sure) this is an issue of lewton. With tremor it doesn't exceed 3MB permanently.

Edit: I've reached 3.7MB with tremor, while Iewton seems to stop at this limit too now. It's really hard to reproduce as it doesn't behave deterministic.

@Johannesd3
Copy link
Contributor Author

Actually I think it's only an issue in dev and I just imagined the same thing happens in tokio_migration when the numbers rose a little. And in dev it happens with both lewton and tremor. So wherever the problem lies, it will probably be fixed by #665.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants