-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better WASAPI audio resampler? #4608
Comments
@slouken: ac32c52 results in build errors with older SDKS. See:
#ifndef AUDCLNT_STREAMFLAGS_SRC_DEFAULT_QUALITY
#define AUDCLNT_STREAMFLAGS_SRC_DEFAULT_QUALITY 0x08000000
#endif
#ifndef AUDCLNT_STREAMFLAGS_AUTOCONVERTPCM
#define AUDCLNT_STREAMFLAGS_AUTOCONVERTPCM 0x80000000
#endif I don't know whether the resulting dll will be compatible with win8x and older. |
OK, I went ahead and pushed ed6eb07 Still don't know whether the resulting dll will be compatible with win8x and older, though. |
@cgutman said in #4604:
WASAPI does actually have a proper resampler available via AUDCLNT_STREAMFLAGS_AUTOCONVERTPCM and AUDCLNT_STREAMFLAGS_SRC_DEFAULT_QUALITY documented here. I've confirmed it works at least back to Windows 7 (haven't tried Vista).
We should evaluate whether this resampler has better performance or quality than SDL's built-in resampler.
The text was updated successfully, but these errors were encountered: