Examples links vorbis, flac and opus but they're not used

[diizzyy]

From what I can tell these libraries aren't used at all but gets linked and are required via cmake/FindSndFile.cmake.

[evpobr]

Hi @diizzyy

Do use use latest version of libsndfile? It was fixed in latest release, all these external libraries are not required if shared (DLL) libsndfile library was found.

[diizzyy]

Hi @evpobr

When using 0.2.1 (release)

....
-- Found SndFile: /usr/local/lib/libsndfile.so (found version "1.0.30")
....

readelf -d work/.build/examples/timewarp-file

Dynamic section at offset 0x1900 contains 32 entries:
  Tag                Type                  Name/Value
 0x000000000000001d RUNPATH              Library runpath: [/usr/ports/audio/libsamplerate/work/.build/src:/usr/local/lib]
 0x0000000000000001 NEEDED               Shared library: [libm.so.5]
 0x0000000000000001 NEEDED               Shared library: [libsamplerate.so.0]
 0x0000000000000001 NEEDED               Shared library: [libsndfile.so.1]
 0x0000000000000001 NEEDED               Shared library: [libvorbisenc.so.2]
 0x0000000000000001 NEEDED               Shared library: [libvorbis.so.0]
 0x0000000000000001 NEEDED               Shared library: [libopus.so.0]
 0x0000000000000001 NEEDED               Shared library: [libFLAC.so.8]
 0x0000000000000001 NEEDED               Shared library: [libogg.so.0]
 0x0000000000000001 NEEDED               Shared library: [libc.so.7]

Perhaps I'm missing something?

Edit: Also occurs using libsndfile 1.0.31

[evpobr]

Yes, overlinking does take place. So far I can't figure out if it's possible to avoid this when using the find module or if it's CMake's fee for cross-platform.

[diizzyy]

I guess it comes from https://github.com/libsndfile/libsamplerate/blob/master/cmake/FindSndFile.cmake#L45 and https://github.com/libsndfile/libsamplerate/blob/master/cmake/FindSndFile.cmake#L46 ?

[evpobr]

The problem is here:

libsamplerate/cmake/FindSndFile.cmake

Line 53 in 7a42f18

INTERFACE_LINK_LIBRARIES "Vorbis::vorbisenc;Opus::opus;FLAC::FLAC")

[diizzyy]

What would be the downside of just removing it?
https://github.com/freebsd/freebsd-ports/blob/main/audio/libsamplerate/files/patch-cmake_FindSndFile.cmake

[evpobr]

Static libsndfile linking will fail. This is common scenario on Windows.

[evpobr]

@diizzyy , please test pull request.

[diizzyy]

@evpobr
Hi, that seems to work on my end at least! Thanks!

[evpobr]

Thanks @diizzyy !