Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung S21: Piece promotion view distorted, misaligned due to large promotion images #2074

Closed
GregWeiher opened this issue Mar 31, 2022 · 4 comments · Fixed by #2111
Closed
Labels

Comments

@GregWeiher
Copy link

GregWeiher commented Mar 31, 2022

Describe the bug
Piece promotion view distorted, misaligned due to large promotion images, see screenshot

To Reproduce
Steps to reproduce the behavior:

  1. Any Attempt to promote a pawn regardless of piece colour, results in issue

Expected behavior
Used to be formatted correctly,

Screenshots
See Screenshot attached
Screenshot_20220331-075304_lichess

Smartphone (please complete the following information):

  • Device: Samsung S21 FE
  • One UI Version: 4.0
  • Android Version: 12
  • Google Play System Update: 01 Feb 2022
  • Baseband Version G990EXXS1BVB5
  • Kernal Version: 5.4.129-23339874-abG990EXXS1BVB8 # 2 Fri Feb 18 10:19:23 KST 2022
  • Build Number SP1A.210812.016.G990EXXS1BVB5

Additional context
Post update of device and then lichess App, the promotion view for both black and white have been misaligned/distorted

  • attempted to uninstall and reinstall, with no change on the app,
  • log out and log back in also did not resolve issue.
  • phone restart also did no resolve issue.
  • lichess version: v7.15.1
@GregWeiher GregWeiher added the bug label Mar 31, 2022
@jas14
Copy link
Collaborator

jas14 commented Apr 17, 2022

@GregWeiher thanks for the detailed report, looks like people are having a similar problem on #2059. I'll leave this issue open since this is on an S21, but you might have some luck with the workarounds described over there.

@jas14 jas14 changed the title Piece promotion view distorted, misaligned due to large promotion images Samsung S21: Piece promotion view distorted, misaligned due to large promotion images Apr 17, 2022
@GregWeiher
Copy link
Author

GregWeiher commented May 15, 2022

@jas14
apologies on the delayed response, issue seems to relate directly to the font size as per the pictures below:
Thus anything other than the smallest font size, will distort the lichess apps view. interestingly, I hadn't realised that the issue was not only with the piece promotion but with everything font related in the app, and it appears that everything is scaled according to the font size setting. curiously though the promotion issue above seems to persist even if the font sizes are changed.

image

@jas14
Copy link
Collaborator

jas14 commented May 15, 2022

@GregWeiher thanks for the investigation, this is very helpful! The issue is that we scale text components to the system base font size. We try to avoid scaling graphical components to font sizes, since that doesn't make as much sense; for example, the board square dimensions (and board piece dimensions) all need to be relative to the board size. Looks like we're not scaling the promo piece components correctly. I'm prepping a PR now to address this.

@svilponis
Copy link

Will this issue ever addressed? Ver 8.0 still has this bug. That's EXTREMELY ANNOYING!
Please revert to early ver 7 code on pawn promotion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants