Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for web+ schema prefix #36

Closed
Kubuxu opened this issue Dec 26, 2015 · 4 comments
Closed

Add support for web+ schema prefix #36

Kubuxu opened this issue Dec 26, 2015 · 4 comments
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Milestone

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Dec 26, 2015

As in chrome 'web+' is only allowed prefix for JS schema handling then most sites will be using it (and using JS to rewrite it to gateway). Accepting it and rewriting it to plain fs would be optional solution.

@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature UX labels Dec 27, 2015
@lidel
Copy link
Member

lidel commented Dec 27, 2015

Yeah, the robustness principle is an important guideline for this add-on.
Due to Chrome's popularity it makes sense to accept yet another protocol variation and normalize it to canonical URIs.

@Kubuxu
Copy link
Member Author

Kubuxu commented Dec 27, 2015

Same thing applies to transforming fs:, fs:// and fs:/// into fs:/.

@lidel
Copy link
Member

lidel commented Dec 27, 2015

Those are already supported.
(As of version 1.3.1 all custom protocol handlers redirect to URL of the custom HTTP gateway.)

@lidel lidel changed the title Add support for web+fs schema Add support for web+ schema prefix Dec 27, 2015
@lidel
Copy link
Member

lidel commented Dec 27, 2015

Renamed the ticket as we should support chrome prefix for all handlers: web+fs:, web+ipfs: and web+ipns: (with / // or ///)

:)

@lidel lidel self-assigned this Dec 27, 2015
@lidel lidel closed this as completed in 6187aa4 Dec 27, 2015
@lidel lidel added this to the v1.4.0 milestone Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants