Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False-positive href rewrites (when "Extended IPFS link support" is enabled) #43

Closed
Kubuxu opened this issue Jan 13, 2016 · 1 comment
Closed

False-positive href rewrites (when "Extended IPFS link support" is enabled) #43

Kubuxu opened this issue Jan 13, 2016 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Jan 13, 2016

It breaks on ipfs's github as it starts with /ipfs/....

On solution would be to push ipfs/notes#92 forward and resolve it in case of /ipfs/... or /ipns/... to confirm if redirection to local gateway should take place.
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Jan 13, 2016
@lidel
Copy link
Member

lidel commented Jan 13, 2016

Yup, will need to stop doing regex-based rewrites due to false-positives like this one.

@lidel lidel changed the title Extended IPFS link support is broken False-positive href rewrites (when "Extended IPFS link support" is enabled) Jan 13, 2016
This was referenced Jan 13, 2016
Closed
Open
@lidel lidel closed this as completed in f696599 Jan 16, 2016
@lidel lidel mentioned this issue Jan 17, 2016
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @Kubuxu