Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Load favicon from URL #118

Closed
kroerig opened this issue Jul 31, 2018 · 1 comment
Closed

Request: Load favicon from URL #118

kroerig opened this issue Jul 31, 2018 · 1 comment
Labels
enhancement Improvements or new features wontfix This will not be worked on

Comments

@kroerig
Copy link

kroerig commented Jul 31, 2018

Hello,

is it possible to add a function that loads the favicon from the website if DKIM is valid. The addon ships with some built-in favicons but it would be nice to see one's own favicon, too.

Thx,

Klaus

@lieser
Copy link
Owner

lieser commented Jul 31, 2018

It is unlikely that this will come. At least I will not add it myself (I would properly except a PR for it, as long as it is not enabled by default).

The favicons were added to allow an easy recognition of a sender, without the need to carefully read the signing domain (SDID). For this to work, the mapping between the SDID and the favicon must come from a trusted source.

Simply loading the favicon from the URL of the SDID would not result in a trusted mapping. Nothing is preventing a malicious website from using the favicon from a different site.

Note that there is an open issue to allow the user to extend the list himself (#83).

You can also always request fo new favicons being added (or add it yourself and create a PR for it). Note that E-Mail providers will not be added to the favicon list.

@lieser lieser closed this as completed Jul 31, 2018
@lieser lieser added enhancement Improvements or new features wontfix This will not be worked on labels Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or new features wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants