Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to 'mass delete' cached DKIM keys #305

Closed
mdavids opened this issue May 20, 2022 · 4 comments
Closed

Ability to 'mass delete' cached DKIM keys #305

mdavids opened this issue May 20, 2022 · 4 comments
Assignees
Labels
enhancement Improvements or new features
Milestone

Comments

@mdavids
Copy link

mdavids commented May 20, 2022

Over the past few years the add-on collected many DKIM keys, but there sees to be no good way of cleaning things up in one go.

I can only select one key at a time and then choose 'delete selected keys'.

And the same applies for the signers rules database.

Would be great if this can be fixed.

Also additional features, such as the ability to sort on columns (like the 'last used' column) would be very useful.

@mdavids mdavids changed the title Ability to 'mass delete' DKIM keys Ability to 'mass delete' cached DKIM keys May 20, 2022
@lieser
Copy link
Owner

lieser commented May 22, 2022

Thanks for the suggestion. The current tables certainly could benefit from some improvements. See also #248.

As a workaround:

  • For the signers rules you could use the export, manually modify the json, and then import them again (replacing the existing rules).
  • For the keys you could use Thunderbird's debugging features to manually interact with the storage, and e.g. delete all stored keys. Deleting some would be harder. Let me know if I should elaborate on that.

@lieser lieser added the enhancement Improvements or new features label May 22, 2022
@mdavids
Copy link
Author

mdavids commented Nov 17, 2023

This sounds complicated (albeit that the signers rules workaround was easy), I still miss a handy way of selecting all or many keys and then 'mass delete' them. Or maybe I miss the point? The button says 'delete selected keys', which suggest one can select more at once, but I can only select one at a time. Am I doing something wrong?

@lieser
Copy link
Owner

lieser commented Nov 20, 2023

Am I doing something wrong?

No you are not, you are just encountering a bad GUI 😅.
I will try to look into it before the next release, and if not to much work will implement the deletion of multiple keys. But no promises.

@lieser lieser added this to the 5.5.0 milestone Nov 20, 2023
@lieser lieser self-assigned this Jan 8, 2024
@lieser
Copy link
Owner

lieser commented Jan 8, 2024

I'm currently trying out switching to the Tabulator library for rendering the tables.
I'm not 100% happy with it, but it has a few advantages like being able to select multiple rows, making the requested mask delete a lot easier.

@mdavids Would be nice if you could try out the attached version and give feedback.
dkim_verifier@pl-2024-01-08-49c77b4.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants