Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple DKIM signatures not properly handled #428

Closed
fraenki opened this issue Jan 22, 2024 · 2 comments
Closed

Multiple DKIM signatures not properly handled #428

fraenki opened this issue Jan 22, 2024 · 2 comments
Labels

Comments

@fraenki
Copy link

fraenki commented Jan 22, 2024

When a mail contains multiple DKIM signatures, the plugin seems to only parse one of them (the first/last). Consider this mail header...

DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple;
	s=AAA; d=example.com;
...
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple;
	s=ZZZ; d=amazonses.com;
...

In this example the mail originated from example.com, but was delivered through Amazon SES (which added it's own DKIM signature).

In this case this leads to a warning that the DKIM signature for amazonses.com does not belong to this domain (supposedly example.com).

Other DKIM verification tools (like Google Header Analyzer) conclude that everything is fine. So I guess only one of these two DKIM signatures is considered by the plugin, which leads to the incorrect warning.

@lieser
Copy link
Owner

lieser commented Jan 22, 2024

Note that the add-on does verify all DKIM signatures, but it will only show one signature. Mainly because of space reasons in the GUI.
More about it in #48 (comment).

My guess is that the signature for example.com fails to verify. The add-on will then consider the valid signature from amazonses.com the "better" one to show.

If you take a look at the log output you should be able to see what happens (best with debug logging enabled) https://github.com/lieser/dkim_verifier/wiki/Debug#view-error-and-debug-messages.

As part of #160, which is planned for the next version, all DKIM signatures will be probably be visible in the GUI. But still not directly in the header. Instead I plan to extend the pop-up for the DKIM button in the header, that currently only has buttons to trigger actions.

@lieser
Copy link
Owner

lieser commented Feb 6, 2024

As you haven't replied yet I'm assuming your questions are answered. If not please reopen the issue.

@lieser lieser closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants