Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No autocomplete for another components arguments #19

Closed
emattias opened this issue May 20, 2020 · 1 comment · Fixed by #20
Closed

No autocomplete for another components arguments #19

emattias opened this issue May 20, 2020 · 1 comment · Fixed by #20

Comments

@emattias
Copy link

emattias commented May 20, 2020

I have defined a components @activeTab argument:

/**
 * @typedef {Object} Args
 * @property {boolean} activeTab;
 */
export default class Button extends Component {
  /**
   * @type {Args}
   */
  args;
}

I do get it suggested in this components template button.hbs:

CleanShot 2020-05-20 at 10 57 39@2x

but when I use that component in another template I dont get it suggested:

CleanShot 2020-05-20 at 10 55 55@2x

Here's a reproduction repo: https://github.com/emattias/els-addon-typed-templates-no-suggestions-repro/tree/master/app/components

@pdud
Copy link
Contributor

pdud commented May 21, 2020

@emattias as an aside I had issues documenting args like that.

#18 (comment)

Either way, lifeart shared a nicer way of doing it today.

/**
 * @typedef {Object} Args
 * @property {boolean} activeTab;
 * @extends Component<Args>
 */
export default class Button extends Component {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants