Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ResultsBar, results-for item is always visible #1176

Closed
jbalsas opened this issue Sep 10, 2018 · 5 comments
Closed

In ResultsBar, results-for item is always visible #1176

jbalsas opened this issue Sep 10, 2018 · 5 comments
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) resolution: wontfix Issues that will no longer be worked on type: bug Issues reporting that Component is not doing what should be done

Comments

@jbalsas
Copy link
Contributor

jbalsas commented Sep 10, 2018

Inside the ManagementToolbar, we render a ResultsBar if isNonnull($totalItems) and ($searchValue or $filterLabels)

However, in ClayResultsBar, we always render the results item no matter the value of $searchValue.

This results when applied (in Liferay Portal) in something like the following screenshot

screen shot 2018-09-10 at 17 43 07

@jbalsas jbalsas added the type: bug Issues reporting that Component is not doing what should be done label Sep 10, 2018
@matuzalemsteles
Copy link
Member

I think we can move the rules that happens in ManagementToolbar to ResultsBar, so we can have this control more refined and also other products that want only the ResultsBar component, will have to obey the rules of the Lexicon...

@jbalsas
Copy link
Contributor Author

jbalsas commented Sep 12, 2018

This is following Lexicon, agreed with @victorvalle 😉

@carloslancha
Copy link
Contributor

@jbalsas according to the use cases and the component mockups, x-results-for should be visible if search value OR filters are provided.

Sample:
image

@matuzalemsteles matuzalemsteles added the comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) label Nov 23, 2018
@matuzalemsteles
Copy link
Member

hey guys, how do we get on with this?

@jbalsas
Copy link
Contributor Author

jbalsas commented Nov 28, 2018

I think based on what @carloslancha said, we can close this as invalid

@jbalsas jbalsas closed this as completed Nov 28, 2018
@jbalsas jbalsas added the resolution: wontfix Issues that will no longer be worked on label Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) resolution: wontfix Issues that will no longer be worked on type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Development

No branches or pull requests

3 participants