Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Given an empty React fragment, our empty-line-between-sibling-elements rule is not properly enforced #1098

Open
1 of 4 tasks
kresimir-coko opened this issue Mar 7, 2023 · 2 comments

Comments

@kresimir-coko
Copy link
Member

Issue type (mark with x)

  • πŸ€” Question
  • πŸ› Bug report
  • 🎁 Feature request
  • πŸ€·β€β™€οΈ Other

Description

Given an empty React fragment <></>, our empty-line-between-sibling-elements rule is not checked. Code example:

<>
	<ClayDropDown.Caption className="pb-0">
		<ClayAutocomplete>
			...
		</ClayAutocomplete>
		// NOTE: It works for these 2 sibling elements
		{selectedItems.length ? (
			<div className="mt-2 selected-elements-wrapper">
				...
			</div>
		) : null}
	</ClayDropDown.Caption>
	<Divider /> // NOTE: This is where it should get triggered, too, but it's not
</>
@kresimir-coko kresimir-coko changed the title Given an empty React fragment <></>, our empty-line-between-sibling-elements rule is not properly enforced Given an empty React fragment, our empty-line-between-sibling-elements rule is not properly enforced Mar 7, 2023
@izaera
Copy link
Member

izaera commented Mar 7, 2023

I think the problem is not just with the empty fragment. I've run SF in frontend-data-set-web too, with changes to the utils/modules.js file and it ignored me 🀷 .

@bryceosterhaus
Copy link
Member

internal ticket, https://issues.liferay.com/browse/LPS-177900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants