This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
add null check #89
Merged
add null check #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes liferay#88 Signed-off-by: Gregory Amerson <gregory.amerson@liferay.com>
|
hey @izaera i would be willing to add an integration test for this, but I'm not sure how! :) |
|
Just started reviewing :) |
Sent from
No worries. We don't have integration tests for the bundler yet as they would be very tricky to set up and we are not sure they are worth the effort (in this moment). However, we have unit tests for the rest of the setup, and believe that's sufficient for now. Anyway, thanks for the contribution :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.