Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Commit e238a5c

Browse files
committed
chore: update JS toolkit dependencies from v2.19.1 to v2.19.2
Because we need this revert: liferay/liferay-js-toolkit#645 Done with: cd packages/liferay-npm-bundler-preset-liferay-dev yarn add \ babel-preset-liferay-standard@2.19.2 \ liferay-npm-bundler-loader-css-loader@2.19.2 \ liferay-npm-bundler-plugin-{exclude-imports,inject-imports-dependencies,inject-peer-dependencies,namespace-packages,replace-browser-modules,resolve-linked-dependencies}@2.19.2 cd ../liferay-npm-scripts yarn add \ liferay-npm-bridge-generator@2.19.2 \ liferay-npm-bundler@2.19.2 Note that we have some cross-project coupling going on here that lead to duplicates in the yarn.lock file: ``` $ yarn why liferay-npm-bundler-plugin-resolve-linked-dependencies 7.97s [wincent/deps] ~/code/liferay-npm-tools [1/4] 🤔 Why do we have the module "liferay-npm-bundler-plugin-resolve-linked-dependencies"...? => Found "liferay-npm-bundler-plugin-resolve-linked-dependencies@2.19.2" - Hoisted from "_project_#liferay-npm-bundler-preset-standard#liferay-npm-bundler-plugin-resolve-linked-dependencies" - Hoisted from "_project_#liferay-npm-bundler-preset-liferay-dev#liferay-npm-bundler-plugin-resolve-linked-dependencies" => Found "liferay-theme-tasks#liferay-npm-bundler-plugin-resolve-linked-dependencies@2.19.1" - Hoisted from "_project_#liferay-npm-scripts#liferay-theme-tasks#liferay-npm-build-tools-common#liferay-npm-bundler-preset-standard#liferay-npm-bundler-plugin-resolve-linked-dependencies" ``` Neither `yarn` nor a `yarn install --force` were enough to get rid of it; had to go with `rm yarn.lock && yarn`. This gets rid of the duplicate dependencies from the liferay-js-toolkit project, but there are a bunch of others in here still, hopefully benign (eg. look at the `@storybook` dupes in there).
1 parent c52308e commit e238a5c

File tree

3 files changed

+3679
-3332
lines changed

3 files changed

+3679
-3332
lines changed

packages/liferay-npm-bundler-preset-liferay-dev/package.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
"description": "Default configuration for liferay-npm-bundler inside liferay-portal.",
55
"main": "config.json",
66
"dependencies": {
7-
"babel-preset-liferay-standard": "2.19.1",
8-
"liferay-npm-bundler-loader-css-loader": "2.19.1",
9-
"liferay-npm-bundler-plugin-exclude-imports": "2.19.1",
10-
"liferay-npm-bundler-plugin-inject-imports-dependencies": "2.19.1",
11-
"liferay-npm-bundler-plugin-inject-peer-dependencies": "2.19.1",
12-
"liferay-npm-bundler-plugin-namespace-packages": "2.19.1",
13-
"liferay-npm-bundler-plugin-replace-browser-modules": "2.19.1",
14-
"liferay-npm-bundler-plugin-resolve-linked-dependencies": "2.19.1"
7+
"babel-preset-liferay-standard": "2.19.2",
8+
"liferay-npm-bundler-loader-css-loader": "2.19.2",
9+
"liferay-npm-bundler-plugin-exclude-imports": "2.19.2",
10+
"liferay-npm-bundler-plugin-inject-imports-dependencies": "2.19.2",
11+
"liferay-npm-bundler-plugin-inject-peer-dependencies": "2.19.2",
12+
"liferay-npm-bundler-plugin-namespace-packages": "2.19.2",
13+
"liferay-npm-bundler-plugin-replace-browser-modules": "2.19.2",
14+
"liferay-npm-bundler-plugin-resolve-linked-dependencies": "2.19.2"
1515
},
1616
"homepage": "https://github.com/liferay/liferay-npm-tools/tree/master/packages/liferay-npm-bundler-preset-liferay-dev",
1717
"repository": {

packages/liferay-npm-scripts/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@
5555
"jest-fetch-mock": "3.0.1",
5656
"liferay-jest-junit-reporter": "1.2.0",
5757
"liferay-lang-key-dev-loader": "^1.0.3",
58-
"liferay-npm-bridge-generator": "2.19.1",
59-
"liferay-npm-bundler": "2.19.1",
58+
"liferay-npm-bridge-generator": "2.19.2",
59+
"liferay-npm-bundler": "2.19.2",
6060
"liferay-npm-bundler-preset-liferay-dev": "4.6.1",
6161
"liferay-theme-tasks": "10.0.2",
6262
"metal-tools-soy": "4.3.2",

0 commit comments

Comments
 (0)