fix: status sheet buttons and height adjustment #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNR500
commented
Sep 18, 2024
| createElementId(ElementId.ScrollableContainer, elementId), | ||
| ); | ||
|
|
||
| export const getHeaderElement = (elementId: string) => |
There was a problem hiding this comment.
Centralised these functions for a consistent way to access the elements
DNR500
commented
Sep 18, 2024
| return () => { | ||
| scrollableContainer.style.removeProperty('height'); | ||
| relativeContainer.style.removeProperty('min-height'); |
There was a problem hiding this comment.
This just needed to be switched to the relativeContainer rather than the scrollableContainer and now also has to override the height using min-height.
chybisov
changed the title
|
Hey! This is your new endopint: https://7082d4bb.widget-lf10126sta.pages.dev |
chybisov
approved these changes
Sep 23, 2024
chybisov
reviewed
Sep 23, 2024
Comment on lines
9
to
14
| const Placeholder = () => { | ||
| return ( | ||
| <Box sx={{ width: '100%', height: 400, backgroundColor: 'red' }}>hello</Box> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Can we remove this testing component?
chybisov
reviewed
Sep 23, 2024
Comment on lines
47
to
51
| feeConfig={{ | ||
| name: 'Flexible fee', | ||
| fee: 0, | ||
| _vcComponent: Placeholder, | ||
| }} |
|
Hey! This is your new endopint: https://2823b02d.widget-lf10126sta.pages.dev |
chybisov
deleted the
LF-10126-status-sheet-buttons-and-height-adjustment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: LF-10126
Changes the layout of the buttons at the bottom of the StatusBottomSheet to horizontal.
Also adds a fix to the useSetContentHeight hook