Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storeShardCheckpoint not catching ConditionalCheckFailedException #384

Open
dselman opened this issue Nov 2, 2020 · 0 comments
Open

storeShardCheckpoint not catching ConditionalCheckFailedException #384

dselman opened this issue Nov 2, 2020 · 0 comments

Comments

@dselman
Copy link

dselman commented Nov 2, 2020

We are seeing logs like this every 10 seconds or so:

ConditionalCheckFailedException: The conditional request failed
at Request.extractError (/app/node_modules/lifion-kinesis/node_modules/aws-sdk/lib/protocol/json.js:51:27)
at Request.callListeners (/app/node_modules/lifion-kinesis/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
at Request.emit (/app/node_modules/lifion-kinesis/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
at Request.emit (/app/node_modules/lifion-kinesis/node_modules/aws-sdk/lib/request.js:683:14)
at Request.transition (/app/node_modules/lifion-kinesis/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/app/node_modules/lifion-kinesis/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /app/node_modules/lifion-kinesis/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request.<anonymous> (/app/node_modules/lifion-kinesis/node_modules/aws-sdk/lib/request.js:38:9)
at Request.<anonymous> (/app/node_modules/lifion-kinesis/node_modules/aws-sdk/lib/request.js:685:12)
at Request.callListeners (/app/node_modules/lifion-kinesis/node_modules/aws-sdk/lib/sequential_executor.js:116:18)

I noticed that the call to storeShardCheckpoint is not protected by the same try/catch as the other calls, which swallows ConditionalCheckFailedException.

Note that we are running with useEnhancedFanOut=true.

Could this explain what we are seeing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant