Skip to content

Commit a0ec294

Browse files
committed
Use mockito-scala-scalatest to enable strict mocks on all tests.
1 parent 053bc47 commit a0ec294

File tree

5 files changed

+101
-94
lines changed

5 files changed

+101
-94
lines changed

project/Dependencies.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ object Version {
1010
}
1111

1212
object Library {
13-
val logbackClassic = "ch.qos.logback" % "logback-classic" % Version.logback
14-
val mockitoScala = "org.mockito" %% "mockito-scala" % Version.mockito
15-
def scalaReflect(scalaVersion: String) = "org.scala-lang" % "scala-reflect" % scalaVersion
16-
val scalaTest = "org.scalatest" %% "scalatest" % Version.scalaTest
17-
val slf4jApi = "org.slf4j" % "slf4j-api" % Version.slf4j
13+
val logbackClassic = "ch.qos.logback" % "logback-classic" % Version.logback
14+
val mockitoScala = "org.mockito" %% "mockito-scala-scalatest" % Version.mockito
15+
def scalaReflect(scalaVersion: String) = "org.scala-lang" % "scala-reflect" % scalaVersion
16+
val scalaTest = "org.scalatest" %% "scalatest" % Version.scalaTest
17+
val slf4jApi = "org.slf4j" % "slf4j-api" % Version.slf4j
1818
}
1919

2020
object Dependencies {

src/test/scala/com/typesafe/scalalogging/LoggerSpec.scala

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
package com.typesafe.scalalogging
22

3-
import java.io._
3+
import org.mockito.scalatest.MockitoSugar
44

5-
import org.mockito.ArgumentMatchers._
6-
import org.mockito.Mockito._
5+
import java.io._
76
import org.slf4j.{ Logger => Underlying }
87
import org.scalatest.matchers.should.Matchers
98
import org.scalatest.wordspec.AnyWordSpec
@@ -14,7 +13,7 @@ trait Varargs {
1413
def forceVarargs[T](xs: T*): scala.Seq[T] = scala.Seq(xs: _*)
1514
}
1615

17-
class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
16+
class LoggerSpec extends AnyWordSpec with Matchers with Varargs with MockitoSugar {
1817

1918
// Error
2019

@@ -31,7 +30,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
3130
val f = fixture(_.isErrorEnabled, isEnabled = false)
3231
import f._
3332
logger.error(msg)
34-
verify(underlying, never).error(anyString)
33+
verify(underlying, never).error(any[String])
3534
}
3635
}
3736

@@ -66,7 +65,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
6665
val f = fixture(_.isErrorEnabled, isEnabled = false)
6766
import f._
6867
logger.error(msg, cause)
69-
verify(underlying, never).error(anyString, any[Object])
68+
verify(underlying, never).error(any[String], any[Object])
7069
}
7170
}
7271

@@ -110,7 +109,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
110109
val f = fixture(_.isWarnEnabled, isEnabled = false)
111110
import f._
112111
logger.warn(msg)
113-
verify(underlying, never).warn(anyString)
112+
verify(underlying, never).warn(any[String])
114113
}
115114
}
116115

@@ -144,7 +143,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
144143
val f = fixture(_.isWarnEnabled, isEnabled = false)
145144
import f._
146145
logger.warn(msg, cause)
147-
verify(underlying, never).warn(anyString, any[Object])
146+
verify(underlying, never).warn(any[String], any[Object])
148147
}
149148
}
150149

@@ -188,7 +187,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
188187
val f = fixture(_.isInfoEnabled, isEnabled = false)
189188
import f._
190189
logger.info(msg)
191-
verify(underlying, never).info(anyString)
190+
verify(underlying, never).info(any[String])
192191
}
193192
}
194193

@@ -222,7 +221,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
222221
val f = fixture(_.isInfoEnabled, isEnabled = false)
223222
import f._
224223
logger.info(msg, cause)
225-
verify(underlying, never).info(anyString, any[Object])
224+
verify(underlying, never).info(any[String], any[Object])
226225
}
227226
}
228227

@@ -266,7 +265,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
266265
val f = fixture(_.isDebugEnabled, isEnabled = false)
267266
import f._
268267
logger.debug(msg)
269-
verify(underlying, never).debug(anyString)
268+
verify(underlying, never).debug(any[String])
270269
}
271270
}
272271
"Calling debug with an interpolated message" should {
@@ -299,7 +298,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
299298
val f = fixture(_.isDebugEnabled, isEnabled = false)
300299
import f._
301300
logger.debug(msg, cause)
302-
verify(underlying, never).debug(anyString, any[Object])
301+
verify(underlying, never).debug(any[String], any[Object])
303302
}
304303
}
305304

@@ -343,7 +342,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
343342
val f = fixture(_.isTraceEnabled, isEnabled = false)
344343
import f._
345344
logger.trace(msg)
346-
verify(underlying, never).trace(anyString)
345+
verify(underlying, never).trace(any[String])
347346
}
348347
}
349348

@@ -377,7 +376,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
377376
val f = fixture(_.isTraceEnabled, isEnabled = false)
378377
import f._
379378
logger.trace(msg, cause)
380-
verify(underlying, never).trace(anyString, any[Object])
379+
verify(underlying, never).trace(any[String], any[Object])
381380
}
382381
}
383382

@@ -587,7 +586,7 @@ class LoggerSpec extends AnyWordSpec with Matchers with Varargs {
587586
val arg5ref = arg5.asInstanceOf[AnyRef]
588587
val arg6 = 6L
589588
val arg6ref = arg6.asInstanceOf[AnyRef]
590-
val underlying = mock(classOf[org.slf4j.Logger])
589+
val underlying = mock[org.slf4j.Logger]
591590
when(p(underlying)).thenReturn(isEnabled)
592591
val logger = Logger(underlying)
593592
}

0 commit comments

Comments
 (0)