Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Add image digests to App CR built by sbt plugin, so that CLI does not need to pull these #390

Closed
RayRoestenburg opened this issue May 1, 2020 · 2 comments
Closed

Add image digests to App CR built by sbt plugin, so that CLI does not need to pull these #390

RayRoestenburg opened this issue May 1, 2020 · 2 comments
Labels
kind/enhancement New feature or request. priority/nice-to-have Low priority item.

Comments

@RayRoestenburg
Copy link
Contributor

No description provided.

@RayRoestenburg
Copy link
Contributor Author

Currently dockerBuildAndPush in the sbt-docker plugin only returns an ImageId. It could return a digest: marcus-drake/sbt-docker#108
Once that would be possible, we can simply set update the image refs in deployments in sbt instead of the CLI. (The CLI then really does not need to pull images, it must only check if authentication is needed)

@RayRoestenburg RayRoestenburg added kind/enhancement New feature or request. priority/nice-to-have Low priority item. labels Jun 17, 2020
@RayRoestenburg
Copy link
Contributor Author

This is now done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/enhancement New feature or request. priority/nice-to-have Low priority item.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RayRoestenburg