Remove global cache for templates to allow changes #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AppVeyor test is failing with some kind of encoding difference in a file that wasn't touched in this PR?
|
|
Sounds related to two of the PR that I just mentioned in https://github.com/lightbend/paradox/releases/tag/v0.2.10. |
|
Opened #111 |
|
Fixed it in #112 |
|
Cool. Thanks! |
pvlugter
force-pushed
the
template-changes
branch
2 times, most recently
from
819abf0
to
4865682
Compare
|
I also bumped master to a snapshot version again for the sbt tests. |
eed3si9n
approved these changes
May 9, 2017
This was referenced May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having templates cached globally means that the template cannot be changed and the docs rebuilt in the same sbt process. So to change the template and rebuild, we need to keep restarting sbt / running in batch mode. Rather than invalidate the cache, I've just removed it completely. StringTemplate already provides caching for the template group, as far as I know. Also move the default template name to an sbt setting.
Also add an sbt-test that makes some changes to the template (and starts by overriding the generic template). This test will fail with the cached templates, without these changes.
Related issues: #91 and #101.