Skip to content

Commit f7a29f4

Browse files
committed
Bump MSRV to rustc 1.85
We generally align our MSRV with Debian's stable channel. Debian 13 'Trixie' was just released, shipping rustc 1.85. We therefore bump our MSRV on the `main` branch here.
1 parent d2cadd0 commit f7a29f4

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

.github/workflows/rust.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
toolchain: [
1919
stable,
2020
beta,
21-
1.75.0, # Our MSRV
21+
1.85.0, # Our MSRV
2222
]
2323
include:
2424
- toolchain: stable
@@ -29,7 +29,7 @@ jobs:
2929
platform: macos-latest
3030
- toolchain: stable
3131
platform: windows-latest
32-
- toolchain: 1.75.0
32+
- toolchain: 1.85.0
3333
msrv: true
3434
runs-on: ${{ matrix.platform }}
3535
steps:
@@ -42,11 +42,9 @@ jobs:
4242
- name: Check formatting on Rust ${{ matrix.toolchain }}
4343
if: matrix.check-fmt
4444
run: rustup component add rustfmt && cargo fmt --all -- --check
45-
- name: Pin packages to allow for MSRV
46-
if: matrix.msrv
47-
run: |
48-
cargo update -p home --precise "0.5.9" --verbose # home v0.5.11 requires rustc 1.81 or newer
49-
cargo update -p idna_adapter --precise "1.1.0" --verbose # idna_adapter 1.2 switched to ICU4X, requiring 1.81 and newer
45+
# - name: Pin packages to allow for MSRV
46+
# if: matrix.msrv
47+
# run:
5048
- name: Set RUSTFLAGS to deny warnings
5149
if: "matrix.toolchain == 'stable'"
5250
run: echo "RUSTFLAGS=-D warnings" >> "$GITHUB_ENV"
@@ -79,7 +77,7 @@ jobs:
7977
if: matrix.build-uniffi
8078
run: cargo build --features uniffi --verbose --color always
8179
- name: Build documentation on Rust ${{ matrix.toolchain }}
82-
if: "matrix.platform != 'windows-latest' || matrix.toolchain != '1.75.0'"
80+
if: "matrix.platform != 'windows-latest' || matrix.toolchain != '1.85.0'"
8381
run: |
8482
cargo doc --release --verbose --color always
8583
cargo doc --document-private-items --verbose --color always

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ LDK Node currently comes with a decidedly opinionated set of design choices:
6464
LDK Node itself is written in [Rust][rust] and may therefore be natively added as a library dependency to any `std` Rust program. However, beyond its Rust API it also offers language bindings for [Swift][swift], [Kotlin][kotlin], and [Python][python] based on the [UniFFI](https://github.com/mozilla/uniffi-rs/). Moreover, [Flutter bindings][flutter_bindings] are also available.
6565

6666
## MSRV
67-
The Minimum Supported Rust Version (MSRV) is currently 1.75.0.
67+
The Minimum Supported Rust Version (MSRV) is currently 1.85.0.
6868

6969
[api_docs]: https://docs.rs/ldk-node/*/ldk_node/
7070
[api_docs_node]: https://docs.rs/ldk-node/*/ldk_node/struct.Node.html

0 commit comments

Comments
 (0)