Skip to content

Channel Closed "message" #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reez opened this issue Feb 9, 2024 · 2 comments · Fixed by #260
Closed

Channel Closed "message" #247

reez opened this issue Feb 9, 2024 · 2 comments · Fixed by #260
Milestone

Comments

@reez
Copy link

reez commented Feb 9, 2024

for the Event of channelClosed(channelId, userChannelId, counterpartyNodeId) any thoughts on adding an additional message item in there?

For instance i tried to open up a channel for 200k sats but saw in the logs that i needed a min 400k which had the message invalid funding_amount=200000 sat (min=400000 sat) which would be nice to bubble up to possibly display to a user as a reason they just saw a channel closed event in the UI when they tried opening the channel (so then they might retry opening the channel with the appropriate channel size above the min).

Screenshot 2024-02-08 at 7 55 40 PM

Just was wondering your thoughts on whether to begin with that was even a good idea or not-

@tnull
Copy link
Collaborator

tnull commented Feb 12, 2024

Yeah, we should eventually expose the reason field.

@reez
Copy link
Author

reez commented Feb 12, 2024

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants