Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate LDK and BDK wallet syncs. #3

Closed
tnull opened this issue Aug 26, 2022 · 2 comments
Closed

Consolidate LDK and BDK wallet syncs. #3

tnull opened this issue Aug 26, 2022 · 2 comments

Comments

@tnull
Copy link
Collaborator

tnull commented Aug 26, 2022

Currently, the two wallet syncs are conducted independently in LdkLiteChainAccess.

As this may be partly redundant, we should try to consolidate the two wallet syncs. Doing this properly might depend on upstream changes (i.e. more traits in BDK), but we could at least try to do a 'dirty' version of this soon.

@tnull
Copy link
Collaborator Author

tnull commented Oct 21, 2022

So, we should also look into making the existing blockchain traits (GetHeight, GetTx, etc.) Send, since this seems to be showstopper that hindered us from using them (vs. the 'raw' esplora client API methods) when migrating to the async BDK interface.

@tnull
Copy link
Collaborator Author

tnull commented Dec 15, 2022

Closing, as partly addressed by better wallet integration, partly by the upcoming upstream lightning-transactions-sync crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant