Upgrade to LDK 0.0.119 #214
Conversation
tnull
force-pushed
the
2023-12-upgrade-to-ldk-0.0.119
branch
from
608f53d to
59da31c
Compare
|
Currently blocked as we need to figure out what to do about the |
tnull
force-pushed
the
2023-12-upgrade-to-ldk-0.0.119
branch
from
59da31c to
e261ba9
Compare
tnull
force-pushed
the
2023-12-upgrade-to-ldk-0.0.119
branch
from
e261ba9 to
8ac035a
Compare
tnull
force-pushed
the
2023-12-upgrade-to-ldk-0.0.119
branch
from
8ac035a to
06db0fb
Compare
There was a problem hiding this comment.
Changes related to onion message and offers PRs all seem fine. Since the OnionMessenger is configured to ignore all messages -- and we don't expose offer creation from ChannelManager -- the FakeMessageRouter should never be reached. Nor does the ConnectionNeeded event need to be handled yet as we'll never see one generated given the above configuration.
| let locked_outputs = self.outputs.lock().unwrap(); | ||
| locked_outputs | ||
| .iter() | ||
| .filter_map(|o| { | ||
| if let Some(confirmation_hash) = o.confirmation_hash { | ||
| if let Some(latest_spending_tx) = o.latest_spending_tx.as_ref() { | ||
| return Some((latest_spending_tx.txid(), Some(confirmation_hash))); | ||
| if let Some(confirmation_height) = o.confirmation_height { |
There was a problem hiding this comment.
Looks like this is duplicated from the previous line.
There was a problem hiding this comment.
Mh, no, oneconfirmation_hash, the other is confirmation_height? Or am I misunderstanding what you're saying?
There was a problem hiding this comment.
Whoops, no, I just misread it.
tnull
force-pushed
the
2023-12-upgrade-to-ldk-0.0.119
branch
from
06db0fb to
c13fe2d
Compare
| let locked_outputs = self.outputs.lock().unwrap(); | ||
| locked_outputs | ||
| .iter() | ||
| .filter_map(|o| { | ||
| if let Some(confirmation_hash) = o.confirmation_hash { | ||
| if let Some(latest_spending_tx) = o.latest_spending_tx.as_ref() { | ||
| return Some((latest_spending_tx.txid(), Some(confirmation_hash))); | ||
| if let Some(confirmation_height) = o.confirmation_height { |
There was a problem hiding this comment.
Whoops, no, I just misread it.
tnull
force-pushed
the
2023-12-upgrade-to-ldk-0.0.119
branch
from
c13fe2d to
c9cd694
Compare
Squashed without further changes. |
We upgrade LDK to 0.0.119, BDK to 0.29.0, and rust-bitcoin to 0.30, esplora-client to 0.6, etc.