Stop serializing peer node ids when forwarding gossip messages

Author: alecchendev

lightning/src/ln/peer_handler.rs

@@ -1480,8 +1480,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, OM: Deref, L: Deref, CM
 						log_gossip!(self.logger, "Skipping broadcast message to {:?} as its outbound buffer is full", peer.their_node_id);
 						continue;
 					}
-					if let Some(their_node_id) = peer.their_node_id {
-						let their_node_id = NodeId::from_pubkey(&their_node_id);
+					if let Some(their_node_id) = peer.their_node_id_serialized {
 						if their_node_id == msg.contents.node_id_1 || their_node_id == msg.contents.node_id_2 {
 							continue;
 						}
@@ -1506,8 +1505,8 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, OM: Deref, L: Deref, CM
 						log_gossip!(self.logger, "Skipping broadcast message to {:?} as its outbound buffer is full", peer.their_node_id);
 						continue;
 					}
-					if let Some(their_node_id) = peer.their_node_id {
-						if NodeId::from_pubkey(&their_node_id) == msg.contents.node_id {
+					if let Some(their_node_id) = peer.their_node_id_serialized {
+						if their_node_id == msg.contents.node_id {
 							continue;
 						}
 					}