Address ChannelState inconsistency throughout splicing

Once a channel open has become locked (i.e., we've entered
`ChannelState::ChannelReady`), the channel is intended to remain within
this state for the rest of its lifetime until shutdown. Previously, we
had assumed a channel being spliced would go through the `ChannelState`
lifecycle again starting from `NegotiatingFunding` but skipping
`AwaitingChannelReady`. This inconsistency departs from what we strive
to achieve with `ChannelState` and also makes the state of a channel
harder to reason about.

This commit ensures a channel undergoing a splice remains in
`ChannelReady`, clearing the quiescent flag once the negotiation is
complete. Dual funding is unaffected by this change as the channel is
being opened and we want to maintain the same `ChannelState` lifecycle.

Author: wpaulino

lightning/src/ln/channel.rs

@@ -1935,6 +1935,18 @@ where
 		let logger = WithChannelContext::from(logger, self.context(), None);
 		match &mut self.phase {
 			ChannelPhase::UnfundedV2(chan) => {
+				debug_assert_eq!(
+					chan.context.channel_state,
+					ChannelState::NegotiatingFunding(
+						NegotiatingFundingFlags::OUR_INIT_SENT
+							| NegotiatingFundingFlags::THEIR_INIT_SENT
+					),
+				);
+
+				chan.context.channel_state =
+					ChannelState::FundingNegotiated(FundingNegotiatedFlags::new());
+				chan.context.channel_state.set_interactive_signing();
+
 				let mut signing_session = chan
 					.interactive_tx_constructor
 					.take()
@@ -6071,9 +6083,6 @@ where
 		funding
 			.channel_transaction_parameters.funding_outpoint = Some(outpoint);
 
-		self.channel_state = ChannelState::FundingNegotiated(FundingNegotiatedFlags::new());
-		self.channel_state.set_interactive_signing();
-
 		if is_splice {
 			debug_assert_eq!(
 				holder_commitment_transaction_number,
@@ -6121,6 +6130,12 @@ where
 		SP::Target: SignerProvider,
 		L::Target: Logger,
 	{
+		let is_quiescent = matches!(
+			self.channel_state,
+			ChannelState::ChannelReady(f) if f.is_set(ChannelReadyFlags::QUIESCENT)
+		);
+		debug_assert!(self.channel_state.is_interactive_signing() || is_quiescent);
+
 		let mut commitment_number = self.counterparty_next_commitment_transaction_number;
 		let mut commitment_point = self.counterparty_next_commitment_point.unwrap();
 
@@ -6167,10 +6182,6 @@ where
 		SP::Target: SignerProvider,
 		L::Target: Logger,
 	{
-		assert!(
-			matches!(self.channel_state, ChannelState::FundingNegotiated(flags) if flags.is_interactive_signing())
-		);
-
 		let signature = self.get_initial_counterparty_commitment_signature(funding, logger);
 		if let Some(signature) = signature {
 			log_info!(
@@ -6201,6 +6212,8 @@ where
 		SP::Target: SignerProvider,
 		L::Target: Logger,
 	{
+		self.channel_state = ChannelState::FundingNegotiated(FundingNegotiatedFlags::new());
+		self.channel_state.set_interactive_signing();
 		self.counterparty_next_commitment_point = Some(counterparty_next_commitment_point_override);
 		self.get_initial_counterparty_commitment_signature(funding, logger)
 	}
@@ -8581,6 +8594,10 @@ where
 				format!("Channel {} not expecting funding signatures", self.context.channel_id);
 			return Err(APIError::APIMisuseError { err });
 		}
+		debug_assert_eq!(
+			self.has_pending_splice_awaiting_signatures(),
+			matches!(self.context.channel_state, ChannelState::ChannelReady(f) if f.is_set(ChannelReadyFlags::QUIESCENT))
+		);
 
 		let signing_session =
 			if let Some(signing_session) = self.interactive_tx_signing_session.as_mut() {
@@ -8631,9 +8648,25 @@ where
 			.map_err(|err| APIError::APIMisuseError { err })?;
 
 		if funding_tx_opt.is_some() {
-			self.funding.funding_transaction = funding_tx_opt.clone();
-			self.context.channel_state =
-				ChannelState::AwaitingChannelReady(AwaitingChannelReadyFlags::new());
+			debug_assert!(tx_signatures_opt.is_some());
+			debug_assert!(!self.context.channel_state.is_monitor_update_in_progress());
+			debug_assert!(!self.context.channel_state.is_awaiting_remote_revoke());
+
+			if let Some(pending_splice) = self.pending_splice.as_mut() {
+				if let Some(FundingNegotiation::AwaitingSignatures(mut funding)) =
+					pending_splice.funding_negotiation.take()
+				{
+					funding.funding_transaction = funding_tx_opt.clone();
+					self.pending_funding.push(funding);
+				} else {
+					debug_assert!(false, "We checked we were in the right state above");
+				}
+				self.context.channel_state.clear_quiescent();
+			} else {
+				self.funding.funding_transaction = funding_tx_opt.clone();
+				self.context.channel_state =
+					ChannelState::AwaitingChannelReady(AwaitingChannelReadyFlags::new());
+			}
 		}
 
 		Ok((tx_signatures_opt, funding_tx_opt))
@@ -8646,6 +8679,10 @@ where
 		{
 			return Err(ChannelError::Ignore("Ignoring unexpected tx_signatures".to_owned()));
 		}
+		debug_assert_eq!(
+			self.has_pending_splice_awaiting_signatures(),
+			matches!(self.context.channel_state, ChannelState::ChannelReady(f) if f.is_set(ChannelReadyFlags::QUIESCENT))
+		);
 
 		let signing_session = if let Some(signing_session) = self.interactive_tx_signing_session.as_mut() {
 			if signing_session.has_received_tx_signatures() {
@@ -8678,12 +8715,24 @@ where
 			.map_err(|msg| ChannelError::Warn(msg))?;
 
 		if funding_tx_opt.is_some() {
-			// TODO(splicing): Transition back to `ChannelReady` and not `AwaitingChannelReady`
-			// We will also need to use the pending `FundingScope` in the splicing case.
-			//
-			// We have a finalized funding transaction, so we can set the funding transaction.
-			self.funding.funding_transaction = funding_tx_opt.clone();
-			self.context.channel_state = ChannelState::AwaitingChannelReady(AwaitingChannelReadyFlags::new());
+			debug_assert!(!self.context.channel_state.is_monitor_update_in_progress());
+			debug_assert!(!self.context.channel_state.is_awaiting_remote_revoke());
+
+			if let Some(pending_splice) = self.pending_splice.as_mut() {
+				if let Some(FundingNegotiation::AwaitingSignatures(mut funding)) =
+					pending_splice.funding_negotiation.take()
+				{
+					funding.funding_transaction = funding_tx_opt.clone();
+					self.pending_funding.push(funding);
+				} else {
+					debug_assert!(false, "We checked we were in the right state above");
+				}
+				self.context.channel_state.clear_quiescent();
+			} else {
+				self.funding.funding_transaction = funding_tx_opt.clone();
+				self.context.channel_state =
+					ChannelState::AwaitingChannelReady(AwaitingChannelReadyFlags::new());
+			}
 		}
 
 		Ok((holder_tx_signatures_opt, funding_tx_opt))