Skip to content

Check for outbound feerate update affordability before sending #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Aug 12, 2021 · 3 comments · Fixed by #1054
Closed

Check for outbound feerate update affordability before sending #1041

TheBlueMatt opened this issue Aug 12, 2021 · 3 comments · Fixed by #1054
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

Turns out we will try to send feerate updates that we cannot at all afford right now. Val caught it in review at #985 (comment) and it seems the chanmon_consistency fuzzer has also found it (or something related).

@ariard
Copy link

ariard commented Aug 16, 2021

I think you should replicate d3af49e to limit outbound fee updates, even if we assume our fee estimator is always more "reasonable" than the counterparty one.

@TheBlueMatt
Copy link
Collaborator Author

We could do that (I think a simpler approach would be to limit upwards fee increase to eg 25% per $TIME_PERIOD), but independently, we don't limit it at all and can overrun our own reserve value!

@ariard
Copy link

ariard commented Aug 16, 2021

I think a simpler approach would be to limit upwards fee increase to eg 25% per $TIME_PERIOD

Right, though such solution would let max_dust_htlc_exposure bypass when real-world fees overflow 25% per $TIME_PERIOD, especially that $TIME_PERIOD isn't fixed for HTLC's CLTV

@TheBlueMatt TheBlueMatt modified the milestones: 0.0.101, 0.0.102 Sep 15, 2021
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.102, 0.0.103 Oct 15, 2021
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.103, 0.1 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants