Skip to content

Fix CI failure to fail when a public method is parameterized by a private item #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
valentinewallace opened this issue Jan 13, 2023 · 0 comments
Open

Fix CI failure to fail when a public method is parameterized by a private item #1949

valentinewallace opened this issue Jan 13, 2023 · 0 comments

Comments

@valentinewallace
Copy link
Contributor

valentinewallace commented Jan 13, 2023 •
edited
Loading

Found on @alecchendev's branch https://github.com/alecchendev/rust-lightning/tree/custom-fail-back-err as part of #1948, commit 60bce30.

The public method ChannelManager::fail_htlc_backwards_with_reason was added and parameterized by HTLCFailReason, and CI passed even though HTLCFailReason is in a private module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@valentinewallace