Skip to content

Generate HTLCHandlingFailed when we don't forward #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TheBlueMatt opened this issue Jan 18, 2023 · 3 comments
Open

Generate HTLCHandlingFailed when we don't forward #1965

TheBlueMatt opened this issue Jan 18, 2023 · 3 comments
Milestone
0.2

Comments

@TheBlueMatt
Copy link
Collaborator

Currently, if we receive an HTLC and decide that we aren't gonna forward it at all, we never generate the HTLCHandlingFailed event, but we should. Followup on #1392
@dunxen
Copy link
Contributor

dunxen commented Apr 14, 2023

I believe the only case where this is not covered is when the short channel ID to forward on is unknown in process_pending_htlc_forwards. Or should I be looking elsewhere too?

@TheBlueMatt
Copy link
Collaborator Author

I know its at least also not generated if the peer is currently disconnected.

@dunxen
Copy link
Contributor

dunxen commented Apr 15, 2023

I know its at least also not generated if the peer is currently disconnected.

Cool. I'll dig a bit deeper.

@TheBlueMatt TheBlueMatt added this to the 0.1.1 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@TheBlueMatt @dunxen