You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, only PaymentFailure::PartialFailure carry PaymentParameters, which is why InvoicePayer retries any PaymentFailure::AllFailedResendSafes with empty previously_failed_channels:
As this may result in a loop where a failing route is retried over and over again until we run out of time or attempts, we probably want to consider any previously failed channels in the AllFailedResendSafe case also.
As InvoicePayer is pending deprecation anyways, this probably should be fixed as part of the migration of the retry logic to ChannelManager.
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
Currently, only
PaymentFailure::PartialFailure
carryPaymentParameters
, which is whyInvoicePayer
retries anyPaymentFailure::AllFailedResendSafe
s with emptypreviously_failed_channels
:rust-lightning/lightning-invoice/src/payment.rs
Lines 524 to 533 in 98417a1
As this may result in a loop where a failing route is retried over and over again until we run out of time or attempts, we probably want to consider any previously failed channels in the
AllFailedResendSafe
case also.As
InvoicePayer
is pending deprecation anyways, this probably should be fixed as part of the migration of the retry logic toChannelManager
.The text was updated successfully, but these errors were encountered: