-
Notifications
You must be signed in to change notification settings - Fork 421
Closed
Labels
good first issueGood for newcomersGood for newcomers
Milestone
Description
To improve the deserialization time of our network graph and address #960, we swapped the PublicKeys describing node ids directly in the graph with a new NodeId struct in #1107. This improved performance greatly, but missed that we're still deserializing PublicKeys a ton when reading a NetworkGraph - we store the original gossip messages in the graph itself with PublicKeys and have to do a bunch of key checking when reading the graph again.
Replacing the PublicKeys in gossip messages with NodeIds should give us yet again a huge speedup in the time it takes to read our network grpah.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers