Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heuristic to LDK code or docs #2499

Closed
moneyball opened this issue Aug 15, 2023 · 7 comments · Fixed by #2534
Closed

Add heuristic to LDK code or docs #2499

moneyball opened this issue Aug 15, 2023 · 7 comments · Fixed by #2534
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@moneyball
Copy link
Contributor

From LDK Discord, @TheBlueMatt:

"Because there’s rarely liquidity limits for reasonable-value payments in the “core” of ln, one trivial heuristic would be to decline to send a pre-flight probe if the amount is > 1/3 of your available outbound liquidity on a channel that’s used for the probe"

"presumably ldk-node should do that for you, but we may want to document these guidelines in rust-lightning too
or have a wrapper which does the checks pre-flight in ChannelManager"

@TheBlueMatt
Copy link
Collaborator

Should be a nice and easy project for someone - just a new ChannelManager method called pre-flight probing or whatever that takes some payment info and fetches a route, sending probes for any paths which use less than 1/3 of the available liquidity on the first-hop.

@ariard
Copy link

ariard commented Aug 17, 2023

I think can be related to #2397

@TheBlueMatt
Copy link
Collaborator

Not really - this issue is in reference to Just In Time probing, and adding the (trivial) method to do that for a single payment. 2397 is about background probing and the machinery to pick who to probe, how often to probe, and do so constantly unrelated to payments.

@jbesraa
Copy link
Contributor

jbesraa commented Aug 20, 2023

keen to pick this up.
I have 2 open prs but one of them looks complete so I hope its ok to pick this.

@tnull
Copy link
Contributor

tnull commented Aug 21, 2023

keen to pick this up. I have 2 open prs but one of them looks complete so I hope its ok to pick this.

Ah, thank you! However, we concluded in lightningdevkit/ldk-node#156 that we'd upstream the code from LDK Node, so the actual work is essentially already done, will open an PR for it soon.

@tnull tnull self-assigned this Aug 21, 2023
@jbesraa
Copy link
Contributor

jbesraa commented Aug 21, 2023

cool, will pick something else 👯

@TheBlueMatt
Copy link
Collaborator

I have 2 open prs but one of them looks complete so I hope its ok to pick this.

Probably a good indication you should go review some other PRs :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants