-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add heuristic to LDK code or docs #2499
Comments
Should be a nice and easy project for someone - just a new |
I think can be related to #2397 |
Not really - this issue is in reference to Just In Time probing, and adding the (trivial) method to do that for a single payment. 2397 is about background probing and the machinery to pick who to probe, how often to probe, and do so constantly unrelated to payments. |
keen to pick this up. |
Ah, thank you! However, we concluded in lightningdevkit/ldk-node#156 that we'd upstream the code from LDK Node, so the actual work is essentially already done, will open an PR for it soon. |
cool, will pick something else 👯 |
Probably a good indication you should go review some other PRs :p |
From LDK Discord, @TheBlueMatt:
"Because there’s rarely liquidity limits for reasonable-value payments in the “core” of ln, one trivial heuristic would be to decline to send a pre-flight probe if the amount is > 1/3 of your available outbound liquidity on a channel that’s used for the probe"
"presumably ldk-node should do that for you, but we may want to document these guidelines in rust-lightning too
or have a wrapper which does the checks pre-flight in ChannelManager"
The text was updated successfully, but these errors were encountered: