Skip to content

tests::basic_threaded_connection_test is flaky on windows #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TheBlueMatt opened this issue Sep 28, 2023 · 1 comment
Open

tests::basic_threaded_connection_test is flaky on windows #2614

TheBlueMatt opened this issue Sep 28, 2023 · 1 comment
Labels
flaky test

Comments

@TheBlueMatt
Copy link
Collaborator

I've seen this a few times, but seems quite rare:


---- tests::basic_threaded_connection_test stdout ----
DEBUG [lightning::ln::peer_handler : lightning\src\ln\peer_handler.rs, 1368] Finished noise handshake for connection with 031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f
TRACE [lightning::ln::peer_handler : lightning\src\ln\peer_handler.rs, 1234] Enqueueing message Init { features: [], networks: Some([43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000]), remote_network_address: None } to 031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f
DEBUG [lightning::ln::peer_handler : lightning\src\ln\peer_handler.rs, 1381] Finished noise handshake for connection with 031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f
TRACE [lightning::ln::peer_handler : lightning\src\ln\peer_handler.rs, 1234] Enqueueing message Init { features: [], networks: Some([43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000]), remote_network_address: None } to 031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f
INFO  [lightning::ln::peer_handler : lightning\src\ln\peer_handler.rs, 1533] Received peer Init message from 031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f: DataLossProtect: not supported, InitialRoutingSync: not supported, UpfrontShutdownScript: not supported, GossipQueries: not supported, VariableLengthOnion: not supported, StaticRemoteKey: not supported, PaymentSecret: not supported, BasicMPP: not supported, Wumbo: not supported, AnchorsNonzeroFeeHtlcTx: not supported, AnchorsZeroFeeHtlcTx: not supported, ShutdownAnySegwit: not supported, Taproot: not supported, OnionMessages: not supported, ChannelType: not supported, SCIDPrivacy: not supported, ZeroConf: not supported, unknown flags: none
INFO  [lightning::ln::peer_handler : lightning\src\ln\peer_handler.rs, 1533] Received peer Init message from 031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f: DataLossProtect: not supported, InitialRoutingSync: not supported, UpfrontShutdownScript: not supported, GossipQueries: not supported, VariableLengthOnion: not supported, StaticRemoteKey: not supported, PaymentSecret: not supported, BasicMPP: not supported, Wumbo: not supported, AnchorsNonzeroFeeHtlcTx: not supported, AnchorsZeroFeeHtlcTx: not supported, ShutdownAnySegwit: not supported, Taproot: not supported, OnionMessages: not supported, ChannelType: not supported, SCIDPrivacy: not supported, ZeroConf: not supported, unknown flags: none
TRACE [lightning::ln::peer_handler : lightning\src\ln\peer_handler.rs, 2118] Handling DisconnectPeer HandleError event in peer_handler for node 031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f
TRACE [lightning::ln::peer_handler : lightning\src\ln\peer_handler.rs, 2237] Disconnecting peer with id 031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f due to DisconnectPeer HandleError
TRACE [lightning::ln::peer_handler : lightning\src\ln\peer_handler.rs, 2256] Handling disconnection of peer 031b84c5567b126440995d3ed5aaba0565d71e1834604819ff9c17f5e9d5dd078f
thread 'tests::basic_threaded_connection_test' panicked at lightning-net-tokio\src\lib.rs:715:9:
assertion failed: !a_handler.disconnected_flag.load(Ordering::SeqCst)
stack backtrace:
   0: std::panicking::begin_panic_handler
             at /rustc/7c76587edc7f5edb73cb8a1c45faa352cd036c62/library\std\src\panicking.rs:595
   1: core::panicking::panic_fmt
             at /rustc/7c76587edc7f5edb73cb8a1c45faa352cd036c62/library\core\src\panicking.rs:67
   2: core::panicking::panic
             at /rustc/7c76587edc7f5edb73cb8a1c45faa352cd036c62/library\core\src\panicking.rs:117
   3: lightning_net_tokio::tests::do_basic_connection_test::async_fn$0
             at .\src\lib.rs:715
   4: lightning_net_tokio::tests::basic_threaded_connection_test::async_block$0
             at .\src\lib.rs:730
   5: tokio::runtime::park::impl$4::block_on::closure$0
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.32.0\src\runtime\park.rs:282
   6: tokio::runtime::coop::with_budget
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.32.0\src\runtime\coop.rs:107
   7: tokio::runtime::coop::budget
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.32.0\src\runtime\coop.rs:73
   8: tokio::runtime::park::CachedParkThread::block_on<core::pin::Pin<ref_mut$<dyn$<core::future::future::Future<assoc$<Output,tuple$<> > > > > > >
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.32.0\src\runtime\park.rs:282
   9: tokio::runtime::context::blocking::BlockingRegionGuard::block_on<core::pin::Pin<ref_mut$<dyn$<core::future::future::Future<assoc$<Output,tuple$<> > > > > > >
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.32.0\src\runtime\context\blocking.rs:66
  10: tokio::runtime::scheduler::multi_thread::impl$0::block_on::closure$0
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.32.0\src\runtime\scheduler\multi_thread\mod.rs:87
  11: tokio::runtime::context::runtime::enter_runtime<tokio::runtime::scheduler::multi_thread::impl$0::block_on::closure_env$0<core::pin::Pin<ref_mut$<dyn$<core::future::future::Future<assoc$<Output,tuple$<> > > > > > >,tuple$<> >
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.32.0\src\runtime\context\runtime.rs:65
  12: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.32.0\src\runtime\scheduler\multi_thread\mod.rs:86
  13: tokio::runtime::runtime::Runtime::block_on<core::pin::Pin<ref_mut$<dyn$<core::future::future::Future<assoc$<Output,tuple$<> > > > > > >
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.32.0\src\runtime\runtime.rs:349
  14: lightning_net_tokio::tests::basic_threaded_connection_test
             at .\src\lib.rs:730
  15: lightning_net_tokio::tests::basic_threaded_connection_test::closure$0
             at .\src\lib.rs:729
  16: core::ops::function::FnOnce::call_once<lightning_net_tokio::tests::basic_threaded_connection_test::closure_env$0,tuple$<> >
             at /rustc/7c76587edc7f5edb73cb8a1c45faa352cd036c62\library\core\src\ops\function.rs:250
  17: core::ops::function::FnOnce::call_once
             at /rustc/7c76587edc7f5edb73cb8a1c45faa352cd036c62/library\core\src\ops\function.rs:250
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    tests::basic_threaded_connection_test

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.17s

error: test failed, to rerun pass `-p lightning-net-tokio --lib`
Error: Process completed with exit code 101.
@tnull
Copy link
Contributor

tnull commented Oct 24, 2023 •
edited
Loading

I just saw test_process_events_multithreaded flake out on the beta channel of unbuntu-lastest and windows-latest:

failures:

---- ln::peer_handler::tests::test_process_events_multithreaded stdout ----
thread 'ln::peer_handler::tests::test_process_events_multithreaded' panicked at lightning\src\ln\peer_handler.rs:3157:13:
assertion failed: val <= 2
stack backtrace:
   0: std::panicking::begin_panic_handler
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library\std\src\panicking.rs:597
   1: core::panicking::panic_fmt
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library\core\src\panicking.rs:72
   2: core::panicking::panic
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library\core\src\panicking.rs:127
   3: lightning::ln::peer_handler::tests::test_process_events_multithreaded
             at .\src\ln\peer_handler.rs:3157
   4: lightning::ln::peer_handler::tests::test_process_events_multithreaded::closure$0
             at .\src\ln\peer_handler.rs:3121
   5: core::ops::function::FnOnce::call_once<lightning::ln::peer_handler::tests::test_process_events_multithreaded::closure_env$0,tuple$<> >
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae\library\core\src\ops\function.rs:250
   6: core::ops::function::FnOnce::call_once
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library\core\src\ops\function.rs:250
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    ln::peer_handler::tests::test_process_events_multithreaded

test result: FAILED. 818 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 755.08s`

@rawgir-7Xoqca-nezgej rawgir-7Xoqca-nezgej mentioned this issue Nov 4, 2023
Open
@TheBlueMatt TheBlueMatt mentioned this issue Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tnull @TheBlueMatt