Skip to content

Add PaymentHash to log Records #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Dec 2, 2023 · 3 comments · Fixed by #2930
Closed

Add PaymentHash to log Records #2767

TheBlueMatt opened this issue Dec 2, 2023 · 3 comments · Fixed by #2930
Labels
good first issue Good for newcomers

Comments

@TheBlueMatt
Copy link
Collaborator

Users often want to track a single HTLC across multiple channels and through the entire pipeline, which should be doable with the new logging metadata wrappers.

@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Dec 2, 2023
@nafisalawalidris
Copy link

Hello @TheBlueMatt, I'm interested in working on this issue and adding PaymentHash to log records. I believe this enhancement will be valuable for users tracking HTLCs across multiple channels and through the entire pipeline.

@TheBlueMatt
Copy link
Collaborator Author

TheBlueMatt commented Dec 14, 2023

Go for it. Probably best to start small and do this iteratively - just add a payment_hash field to Record and set it in a few places, then go through the channel[manager].rs code iteratively and open new PRs to add the record in new sections of the code.

@jbesraa
Copy link
Contributor

jbesraa commented Mar 8, 2024

hey @nafisalawalidris
are you still interested in doing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants