Skip to content

Errors not being handled during ChannelManager::accept_inbound_channel #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wvanlint opened this issue Mar 15, 2024 · 0 comments · Fixed by #2953
Closed

Errors not being handled during ChannelManager::accept_inbound_channel #2941

wvanlint opened this issue Mar 15, 2024 · 0 comments · Fixed by #2953
Assignees
Milestone

Comments

@wvanlint
Copy link
Contributor

We've heard about inbound channel requests stalling on the client-side when they fall outside of handshake limits. It seems that when we call accept_inbound_channel and InboundV1Channel::new fails due to the limits, the Close error gets mapped to an APIError instead of being handled.

InboundV1Channel::new(&self.fee_estimator, &self.entropy_source, &self.signer_provider,
counterparty_node_id.clone(), &self.channel_type_features(), &peer_state.latest_features,
&unaccepted_channel.open_channel_msg, user_channel_id, &self.default_configuration, best_block_height,
&self.logger, accept_0conf).map_err(|e| {
let err_str = e.to_string();
log_error!(logger, "{}", err_str);
APIError::ChannelUnavailable { err: err_str }
})
}
We also can't call ChannelManager::force_close_without_broadcasting_txn after the failure since the channel is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants